Fix error case in Windows layer cleanup#5328
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jun 3, 2021
Merged
Conversation
Member
Author
|
@TBBle FYI in case you are interested |
ForceRemoveAll has special logic on Windows for cleaning up a Windows snapshotter directory. The logic was missing proper handling for an error case that can be returned in some cases. This fixes the CI failure seen in containerd#5326. Signed-off-by: Kevin Parsons <[email protected]>
|
Build succeeded.
|
Contributor
|
Oh weird, I thought I tested that case, and it silently succeeded for me. Perhaps this case is different on Windows 10 20H2 (where I tested it) vs RS5 on CI. It's possible I'm misremembering, but I believe I tested it by bailing out of a test between Activate and Prepare. Either way, seems reasonable to me. |
TBBle
reviewed
Apr 9, 2021
Member
|
close/reopen to trigger CI |
|
Build succeeded.
|
TBBle
approved these changes
Apr 14, 2021
kzys
approved these changes
Apr 15, 2021
Member
|
@containerd/committers Can someone take a look? |
crosbymichael
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForceRemoveAll has special logic on Windows for cleaning up a Windows
snapshotter directory. The logic was missing proper handling for an
error case that can be returned in some cases.
This fixes the CI failure seen in #5326.
Signed-off-by: Kevin Parsons [email protected]