go.mod: github.com/Microsoft/hcsshim v0.8.16#5326
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Apr 10, 2021
Merged
Conversation
Member
Author
|
Build succeeded.
|
Member
|
Looks like test cleanup failed on Windows due to a layer issue. Any idea if we've seen that in CI recently? |
Member
Author
Hmm.. not sure; I recall #5133 was merged recently (which I think was to fix that?) |
full diff: microsoft/hcsshim@v0.8.15...v0.8.16 also updating github.com/Microsoft/hcsshim/test to current master Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Build succeeded.
|
Member
|
The CI failure was due to I did some testing and this seems to be another error case that the cleanup needs to handle. I've pushed #5328 to address this. |
kevpar
added a commit
to kevpar/containerd
that referenced
this pull request
Apr 9, 2021
ForceRemoveAll has special logic on Windows for cleaning up a Windows snapshotter directory. The logic was missing proper handling for an error case that can be returned in some cases. This fixes the CI failure seen in containerd#5326. Signed-off-by: Kevin Parsons <[email protected]>
dmcgowan
approved these changes
Apr 10, 2021
fahedouch
pushed a commit
to fahedouch/containerd
that referenced
this pull request
Oct 15, 2021
ForceRemoveAll has special logic on Windows for cleaning up a Windows snapshotter directory. The logic was missing proper handling for an error case that can be returned in some cases. This fixes the CI failure seen in containerd#5326. Signed-off-by: Kevin Parsons <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: microsoft/hcsshim@v0.8.15...v0.8.16
also updating github.com/Microsoft/hcsshim/test to current master