Skip to content

integration: use busybox:1.32.0 since latest is unavailable#5320

Closed
fuweid wants to merge 1 commit intocontainerd:masterfrom
fuweid:use-1.32-busybox
Closed

integration: use busybox:1.32.0 since latest is unavailable#5320
fuweid wants to merge 1 commit intocontainerd:masterfrom
fuweid:use-1.32-busybox

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Apr 8, 2021 •
edited
Loading 

curl -s https://mirror.gcr.io//v2/library/busybox/tags/list | jq '[.tags ]'
[
  [
    "1.26.2",
    "1.27.2",
    "1.28",
    "1.29",
    "1.29.2",
    "1.30",
    "1.30.1",
    "1.31",
    "1.31.0",
    "1.31.1",
    "1.32.0"
  ]
]

The latest is gone. I think we should setup image in github container
registry for CI if possible.

Signed-off-by: Wei Fu [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@fuweid
integration: use busybox:1.32.0 since latest is unavailable
21ebeef 
```bash
curl -s https://mirror.gcr.io//v2/library/busybox/tags/list | jq '[.tags ]'
[
  [
    "1.26.2",
    "1.27.2",
    "1.28",
    "1.29",
    "1.29.2",
    "1.30",
    "1.30.1",
    "1.31",
    "1.31.0",
    "1.31.1",
    "1.32.0"
  ]
]
```

The latest is gone. I think we should setup image in github container
registry for CI if possible.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid force-pushed the use-1.32-busybox branch from 0539156 to 21ebeef Compare April 8, 2021 09:35
@fuweid fuweid changed the title integration: use busybox:1.32 since latest is unavailable integration: use busybox:1.32.0 since latest is unavailable Apr 8, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 8, 2021

Looks like there's a failure; probably introduced in #5253, but not sure why it passed on that PR and is failing here

--- FAIL: TestSetOOMScoreBoundaries (0.01s)
    oom_linux_test.go:79: assertion failed: 0 (adjustment int) != -1000 (OOMScoreAdjMin int)
FAIL

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 8, 2021

I think I see the problem; it should only perform that part of the test if the parent process does not have a OOM score set, or its score is -1000;

containerd/sys/oom_linux_test.go

Line 74 in 1edab60

if score == 0 || score == OOMScoreAdjMin {

However I think there's a bug / not clearly defined behavior in GetOOMScoreAdj, as it conflates "no oom score set" with "oom score is 0";

containerd/sys/oom_linux.go

Lines 68 to 76 in 1edab60

// GetOOMScoreAdj gets the oom score for a process
func GetOOMScoreAdj(pid int) (int, error) {
path := fmt.Sprintf("/proc/%d/oom_score_adj", pid)
data, err := ioutil.ReadFile(path)
if err != nil {
return 0, err
}
return strconv.Atoi(strings.TrimSpace(string(data)))
}

The err != nil case means "no score set", whereas other cases could be score is set, but 0 (if we need to differentiate, it should probably return a pointer?)

@thaJeztah thaJeztah mentioned this pull request Apr 8, 2021
Merged
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 8, 2021

Opened #5321 to fix the test

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 8, 2021 •
edited
Loading

mirror.gcr.io is quite unstable, can we switch back to Docker Hub?

I'm not seeing rate limit error on GHA macOS recently.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 8, 2021

mirror.gcr.io is quite unstable, can we switch back to Docker Hub?

SGTM!

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 8, 2021

I'm not seeing rate limit error on GHA macOS recently.

FWIW, I'm also checking with the hub team (I know there's work-in-progress to allow "read-only tokens" for authenticating; which would allow authenticating, without leaking credentials in public CI situations)

@fuweid fuweid closed this Apr 8, 2021
@fuweid fuweid deleted the use-1.32-busybox branch April 9, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fuweid @thaJeztah @AkihiroSuda