Skip to content

Add snapshotter cli option to containerd-stress utility#5316

Merged
estesp merged 1 commit intocontainerd:masterfrom
alakesh:stress-snapshotter-cli-option
Apr 13, 2021
Merged

Add snapshotter cli option to containerd-stress utility#5316
estesp merged 1 commit intocontainerd:masterfrom
alakesh:stress-snapshotter-cli-option

Conversation

@alakesh
Copy link
Copy Markdown
Contributor

@alakesh alakesh commented Apr 6, 2021

containerd-stress utility does not have an option to pass snapshotter. This adds a cli option to pass other snapshotter e.g. devmapper. This is useful for comparing two different snapshotters.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 6, 2021

Hi @alakesh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alakesh alakesh changed the title Stress snapshotter cli option Add snapshotter cli option to containerd-stress utility Apr 6, 2021
@alakesh alakesh marked this pull request as draft April 6, 2021 23:19
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

@alakesh alakesh force-pushed the stress-snapshotter-cli-option branch from 247e5e0 to 527835c Compare April 6, 2021 23:24
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

@alakesh alakesh marked this pull request as ready for review April 6, 2021 23:31
ktock
ktock reviewed Apr 7, 2021
View reviewed changes
Comment thread cmd/containerd-stress/main.go Outdated
@alakesh alakesh force-pushed the stress-snapshotter-cli-option branch from 527835c to c1a3294 Compare April 8, 2021 05:50
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@alakesh alakesh force-pushed the stress-snapshotter-cli-option branch from c1a3294 to 2f06bde Compare April 12, 2021 17:53
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@alakesh
containerd-stress: add snapshotter option for stress test to use
0550c32 
containerd-stress utility needs to be able to run with snapshotter
passed by user in cli in order to be able to stress test snapshotters.
This adds a cli option --snapshotter="<snapshotter-name>"

Signed-off-by: Alakesh Haloi <[email protected]>
@alakesh alakesh force-pushed the stress-snapshotter-cli-option branch from 2f06bde to 0550c32 Compare April 12, 2021 20:45
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

estesp
estesp approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 984aa33 into containerd:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@ktock ktock ktock approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alakesh @k8s-ci-robot @estesp @ktock