Skip to content

Temporarily disable cri-tools critest#5315

Merged
fuweid merged 1 commit intocontainerd:masterfrom
dmcgowan:disable-broken-cri-tools-critest
Apr 7, 2021
Merged

Temporarily disable cri-tools critest#5315
fuweid merged 1 commit intocontainerd:masterfrom
dmcgowan:disable-broken-cri-tools-critest

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Apr 6, 2021

cri-tools is hardcoded to use images which are broken within their registry. Disable the tests to unblock CI until fixed.

See kubernetes-sigs/cri-tools#733

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

@dmcgowan dmcgowan force-pushed the disable-broken-cri-tools-critest branch 2 times, most recently from a33f7b7 to a2169dd Compare April 6, 2021 17:57
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

cri-tools is hardcoded to use images which are broken
within their registry. Disable the tests to unblock
CI until fixed.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the disable-broken-cri-tools-critest branch from a2169dd to 58a0775 Compare April 6, 2021 18:05
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Apr 6, 2021

lol, can't win:

image

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 3db5af9 into containerd:master Apr 7, 2021
@dmcgowan dmcgowan deleted the disable-broken-cri-tools-critest branch March 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants