pkg/cri/opts.WithoutRunMount -> oci.WithoutRunMount#5312
Merged
mxpv merged 1 commit intocontainerd:masterfrom Apr 7, 2021
Merged
pkg/cri/opts.WithoutRunMount -> oci.WithoutRunMount#5312mxpv merged 1 commit intocontainerd:masterfrom
mxpv merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
ktock
approved these changes
Apr 6, 2021
ktock
reviewed
Apr 6, 2021
Move `pkg/cri/opts.WithoutRunMount` function to `oci.WithoutRunMount` so that it can be used without dependency on CRI. Also add `oci.WithoutMounts(dests ...string)` for generality. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
expose-WithoutRunMount
branch
from
51732c7 to
8ba8533
Compare
|
Build succeeded.
|
ktock
approved these changes
Apr 7, 2021
mxpv
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
pkg/cri/opts.WithoutRunMountfunction tooci.WithoutRunMountso that it can be used without dependency on CRI.Also add
oci.WithoutMounts(dests ...string)for generality.Will be used by nerdctl: containerd/nerdctl#158