adds description for hosts.toml#5309
Merged
estesp merged 2 commits intocontainerd:masterfrom May 12, 2021
Merged
Conversation
|
Build succeeded.
|
mikebrow
force-pushed
the
document-hosts.toml
branch
from
165431f to
0c1dba0
Compare
|
Build succeeded.
|
mikebrow
force-pushed
the
document-hosts.toml
branch
from
0c1dba0 to
cfe793b
Compare
|
Build succeeded.
|
Member
|
Thanks for adding, A few notes
|
Member
|
I've added the issue to 1.5 milestone. While the release note explains the file format briefly, we should have this document in addition to the release note. Thoughts? |
dims
reviewed
Apr 22, 2021
mikebrow
force-pushed
the
document-hosts.toml
branch
4 times, most recently
from
d4f4d57 to
6150556
Compare
mikebrow
changed the title
mikebrow
force-pushed
the
document-hosts.toml
branch
2 times, most recently
from
427c282 to
0cfaaf5
Compare
|
Build succeeded.
|
Signed-off-by: Mike Brown <[email protected]>
mikebrow
force-pushed
the
document-hosts.toml
branch
from
0cfaaf5 to
b59e297
Compare
|
Build succeeded.
|
kzys
reviewed
May 3, 2021
mikebrow
force-pushed
the
document-hosts.toml
branch
2 times, most recently
from
c9a00f3 to
07420d7
Compare
|
Build succeeded.
|
estesp
reviewed
May 12, 2021
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
Looks good overall; just some final formatting/typo comments/fixups
Signed-off-by: Mike Brown <[email protected]>
mikebrow
force-pushed
the
document-hosts.toml
branch
from
07420d7 to
6e249b1
Compare
Member
Author
thx... resolved. |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting together some docs to describe configuring registries, authentication, and mirrors.
Signed-off-by: Mike Brown [email protected]