Skip to content

fix the 404 link in docs/cri/config.md#5307

Merged
estesp merged 1 commit intocontainerd:masterfrom
maoyangLiu:fix-url
Apr 13, 2021
Merged

fix the 404 link in docs/cri/config.md#5307
estesp merged 1 commit intocontainerd:masterfrom
maoyangLiu:fix-url

Conversation

@maoyangLiu
Copy link
Copy Markdown
Contributor

@maoyangLiu maoyangLiu commented Apr 5, 2021

I find the link in docs/cri/config.md is outdate,so I fix it.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 5, 2021

Hi @maoyangLiu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 5, 2021

Build succeeded.

@ktock
Copy link
Copy Markdown
Member

ktock commented Apr 5, 2021 

- FAIL - does not have a valid DCO

sign your commit please.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

@ktock
Copy link
Copy Markdown
Member

ktock commented Apr 8, 2021

Also, please squash the commits.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@ktock
Copy link
Copy Markdown
Member

ktock commented Apr 13, 2021

@maoyangLiu Could you rebase it on the latest master?
This will solve the CI flakiness.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@maoyangLiu maoyangLiu closed this Apr 13, 2021
@maoyangLiu
fix the 404 url
abd4be0 
Signed-off-by: maoyangLiu <[email protected]>
@maoyangLiu
Copy link
Copy Markdown
Contributor Author

maoyangLiu commented Apr 13, 2021

open again

@maoyangLiu maoyangLiu reopened this Apr 13, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

mikebrow
mikebrow approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your first contribution!

estesp
estesp approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 2305f05 into containerd:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maoyangLiu @k8s-ci-robot @ktock @estesp @mikebrow