Skip to content

remove two very old no longer used runtime options#5303

Merged
fuweid merged 1 commit intocontainerd:masterfrom
mikebrow:cri-remove-deprecated-default-untrusted
Apr 7, 2021
Merged

remove two very old no longer used runtime options#5303
fuweid merged 1 commit intocontainerd:masterfrom
mikebrow:cri-remove-deprecated-default-untrusted

Conversation

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow mikebrow commented Apr 2, 2021

These are not used anymore.. time to remove them entirely.

I tested config.toml with and without these deprecated items. Ignores either way..

Signed-off-by: Mike Brown [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 2, 2021

Build succeeded.

@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Apr 2, 2021

/test pull-containerd-node-e2e

@mikebrow mikebrow added area/cri Container Runtime Interface (CRI) kind/docs priority/P1 labels Apr 2, 2021
@mikebrow mikebrow added this to the 1.5 milestone Apr 2, 2021
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow force-pushed the cri-remove-deprecated-default-untrusted branch from 627d1ad to 0186a32 Compare April 7, 2021 01:41
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 7, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants