Add OCI ref.name to unique key in remotes handler#5299
Merged
estesp merged 1 commit intocontainerd:masterfrom Apr 1, 2021
Merged
Add OCI ref.name to unique key in remotes handler#5299estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
dmcgowan
reviewed
Apr 1, 2021
This allows a pusher to be used for more than one tag without creating a new resolver/pusher. The current implementation checks the ref key tracker status based on type and hash and will skip the push even if the repository reference is unique. Signed-off-by: Phil Estes <[email protected]>
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a pusher to be used for more than one tag without creating a
new resolver/pusher. The current implementation checks the ref key
tracker status based on type and hash and will skip the push even if the
repository reference is unique.
Signed-off-by: Phil Estes [email protected]
Note: refkeys are visually used in
ctr images pullfor status, which will be impacted by this change, but many images do not use the OCI annotations at this point, so impact seems minimal; for example with this patch, you can see the official alpine image has noref.nameannotation so the output is unchanged: