Skip to content

Fix return event publishing error #5293

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
wzshiming:fix/eveny-error-message
Apr 14, 2021
Merged

Fix return event publishing error #5293
dmcgowan merged 1 commit intocontainerd:masterfrom
wzshiming:fix/eveny-error-message

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

@wzshiming wzshiming commented Mar 31, 2021

Fix that the returned event publishing error may contain historical error messages and memory leaks

Signed-off-by: Shiming Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 31, 2021

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 31, 2021

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Mar 31, 2021

Change looks good, the CI check doesn't like the long single line commit message though

@wzshiming wzshiming force-pushed the fix/eveny-error-message branch from 969ecc9 to 2a5d8c1 Compare April 1, 2021 02:15
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 1, 2021

Build succeeded.

@wzshiming
Copy link
Copy Markdown
Contributor Author

wzshiming commented Apr 1, 2021

Thanks, updated.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 7, 2021

@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 8, 2021

@wzshiming please rebase to fix the CI issue. Thanks

@wzshiming wzshiming force-pushed the fix/eveny-error-message branch from 2a5d8c1 to edf8e83 Compare April 8, 2021 02:46
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@wzshiming wzshiming force-pushed the fix/eveny-error-message branch from edf8e83 to d744fd0 Compare April 8, 2021 03:42
@wzshiming
Copy link
Copy Markdown
Contributor Author

wzshiming commented Apr 8, 2021 •
edited
Loading

@wzshiming please rebase to fix the CI issue. Thanks

@fuweid
Done.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 9, 2021

@wzshiming the CI issue has been fixed. would you rebase the master again? sorry for any inconvenient.

@wzshiming wzshiming force-pushed the fix/eveny-error-message branch from d744fd0 to 45df696 Compare April 9, 2021 03:55
@wzshiming
Copy link
Copy Markdown
Contributor Author

wzshiming commented Apr 9, 2021

@fuweid
Done.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 9, 2021

Build succeeded.

fuweid
fuweid approved these changes Apr 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 13, 2021

@dmcgowan ptal

@dmcgowan dmcgowan merged commit 5c6ea7f into containerd:master Apr 14, 2021
@wzshiming wzshiming deleted the fix/eveny-error-message branch April 14, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

@ktock ktock ktock approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wzshiming @k8s-ci-robot @dmcgowan @fuweid @thaJeztah @ktock