tests: Symlink volume tests by claudiubelu · Pull Request #5284 · containerd/containerd

claudiubelu · 2021-03-30T11:50:57Z

There was a known issue regarding how the symlink files mounted as volumes were being handled on Windows. This commit adds tests that will check against those issue to ensure there won't be any regressions.

Related issue: #4915

Signed-off-by: Claudiu Belu [email protected]

k8s-ci-robot · 2021-03-30T11:51:05Z

Hi @claudiubelu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-03-30T12:09:22Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 16m 48s (non-voting)

theopenlab-ci · 2021-04-06T13:59:01Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 53s (non-voting)

theopenlab-ci · 2021-04-12T16:48:19Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 48s (non-voting)

theopenlab-ci · 2021-04-12T19:45:18Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 49s (non-voting)

thaJeztah · 2021-04-13T21:53:25Z

@kevpar @TBBle ptal

theopenlab-ci · 2021-04-19T13:40:24Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 39s (non-voting)

TBBle · 2021-04-19T14:12:21Z

I haven't looked about to see what the idiom is, but I would have found this clearer to read in the test itself if this was createFileFn, so I was looking for a variable named test, not an imported module named test.

Sure, will rename test to testCase and createFile to createFileFn. I was doing something similar to this: https://github.com/containerd/containerd/blob/master/integration/pod_hostname_test.go#L36

claudiubelu

/ok-to-test

claudiubelu · 2021-04-19T14:43:45Z

Sure, will rename test to testCase and createFile to createFileFn. I was doing something similar to this: https://github.com/containerd/containerd/blob/master/integration/pod_hostname_test.go#L36

k8s-ci-robot · 2021-04-19T14:50:17Z

@claudiubelu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-04-19T15:02:32Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 52s (non-voting)

kzys

LGTM!

/ok-to-test

theopenlab-ci · 2021-04-28T08:48:06Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 48s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 30s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 18m 35s (non-voting)

theopenlab-ci · 2021-04-28T09:35:59Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 47s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 36s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 23m 07s (non-voting)

theopenlab-ci · 2021-04-28T17:30:10Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 44s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 37s (non-voting)
containerd-integration-test-arm64 : FAILURE in 29m 13s (non-voting)

theopenlab-ci · 2021-04-29T10:22:14Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 47s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 18s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 23m 38s (non-voting)

theopenlab-ci · 2021-04-30T10:35:34Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 57s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 23m 32s (non-voting)

theopenlab-ci · 2021-05-13T14:00:38Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 7m 20s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 32s (non-voting)
containerd-integration-test-arm64 : FAILURE in 21m 47s (non-voting)

theopenlab-ci · 2021-05-17T11:11:52Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 55s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 39s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 22m 11s (non-voting)

theopenlab-ci · 2021-05-17T14:00:55Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 46s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 33s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 22m 02s (non-voting)

kzys

@containerd/committers Can someone take a look?

samuelkarp

LGTM

theopenlab-ci · 2021-06-01T15:32:17Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 52s (non-voting)
containerd-test-arm64 : SUCCESS in 6m 24s (non-voting)
containerd-integration-test-arm64 : FAILURE in 20m 48s (non-voting)

thaJeztah · 2021-06-01T21:42:32Z

Oh! Sorry, I see you used the "suggestions" option on GitHub to include my suggested changes, but unfortunately that adds a commit without a correct DCO sign-off 😞

   * ac4e56b0 "Update integration/container_volume_test.go" ... FAIL
    - PASS - commit does not have any whitespace errors
    - FAIL - does not have a valid DCO

Could you squash the two commits, and make sure it has your DCO (signed-off-by)? Sorry for that, I always forget that happens.

theopenlab-ci · 2021-06-02T12:53:36Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-test-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-integration-test-arm64 : NODE_FAILURE in 0s (non-voting)

thaJeztah

LGTM

There was a known issue regarding how the symlink files mounted as volumes were being handled on Windows. This commit adds tests that will check against those issue to ensure there won't be any regressions. Signed-off-by: Claudiu Belu <[email protected]>

theopenlab-ci · 2021-06-03T13:28:03Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-test-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-integration-test-arm64 : NODE_FAILURE in 0s (non-voting)

k8s-ci-robot added the needs-ok-to-test label Mar 30, 2021

claudiubelu force-pushed the test-symlinks branch 2 times, most recently from b6b8902 to 2d3b4ca Compare April 6, 2021 13:51

claudiubelu force-pushed the test-symlinks branch from 2d3b4ca to 92b462b Compare April 12, 2021 16:41

claudiubelu force-pushed the test-symlinks branch from 92b462b to 6dceda9 Compare April 12, 2021 19:38

kzys reviewed Apr 14, 2021

View reviewed changes

Comment thread integration/main_test.go Outdated

Comment thread integration/container_volume_test.go Outdated

Comment thread integration/container_volume_test.go Outdated

claudiubelu force-pushed the test-symlinks branch from 6dceda9 to f5a3118 Compare April 19, 2021 13:33

TBBle reviewed Apr 19, 2021

View reviewed changes

Comment thread integration/container_volume_test.go Outdated

TBBle reviewed Apr 19, 2021

View reviewed changes

Comment thread integration/container_volume_test.go Outdated

TBBle reviewed Apr 19, 2021

View reviewed changes

TBBle approved these changes Apr 19, 2021

View reviewed changes

claudiubelu commented Apr 19, 2021

View reviewed changes

claudiubelu force-pushed the test-symlinks branch from f5a3118 to 67ad1c6 Compare April 19, 2021 14:54

TBBle approved these changes Apr 19, 2021

View reviewed changes

kzys approved these changes Apr 21, 2021

View reviewed changes

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Apr 21, 2021

claudiubelu force-pushed the test-symlinks branch from 67ad1c6 to d5addee Compare April 28, 2021 08:27

claudiubelu force-pushed the test-symlinks branch from d5addee to 9332bea Compare April 28, 2021 09:11

claudiubelu force-pushed the test-symlinks branch from 9332bea to ec14d90 Compare April 28, 2021 16:59

claudiubelu force-pushed the test-symlinks branch from ec14d90 to 7d0ca13 Compare April 29, 2021 09:57

claudiubelu force-pushed the test-symlinks branch from 7d0ca13 to 2d83dbd Compare April 30, 2021 10:10

claudiubelu force-pushed the test-symlinks branch from 2d83dbd to 99077b7 Compare May 13, 2021 13:37

claudiubelu force-pushed the test-symlinks branch from 99077b7 to f49d1b4 Compare May 17, 2021 10:47

claudiubelu force-pushed the test-symlinks branch from f49d1b4 to f38cd87 Compare May 17, 2021 13:36

kzys approved these changes May 27, 2021

View reviewed changes

samuelkarp approved these changes May 30, 2021

View reviewed changes

thaJeztah reviewed May 31, 2021

View reviewed changes

Comment thread integration/container_volume_test.go Outdated

claudiubelu force-pushed the test-symlinks branch from ac4e56b to 64b9ddb Compare June 2, 2021 12:52

thaJeztah approved these changes Jun 2, 2021

View reviewed changes

tests: Symlink volume tests

93e268f

There was a known issue regarding how the symlink files mounted as volumes were being handled on Windows. This commit adds tests that will check against those issue to ensure there won't be any regressions. Signed-off-by: Claudiu Belu <[email protected]>

claudiubelu force-pushed the test-symlinks branch from 64b9ddb to 93e268f Compare June 3, 2021 13:26

crosbymichael approved these changes Jun 3, 2021

View reviewed changes

crosbymichael merged commit 265b394 into containerd:master Jun 3, 2021

Conversation

claudiubelu commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 30, 2021

Uh oh!

theopenlab-ci Bot commented Mar 30, 2021

Uh oh!

theopenlab-ci Bot commented Apr 6, 2021

Uh oh!

theopenlab-ci Bot commented Apr 12, 2021

Uh oh!

theopenlab-ci Bot commented Apr 12, 2021

Uh oh!

thaJeztah commented Apr 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theopenlab-ci Bot commented Apr 19, 2021

Uh oh!

Uh oh!

Uh oh!

TBBle Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

claudiubelu Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

claudiubelu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

claudiubelu Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 19, 2021

Uh oh!

theopenlab-ci Bot commented Apr 19, 2021

Uh oh!

kzys left a comment

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci Bot commented Apr 28, 2021

Uh oh!

theopenlab-ci Bot commented Apr 28, 2021

Uh oh!

theopenlab-ci Bot commented Apr 28, 2021

Uh oh!

theopenlab-ci Bot commented Apr 29, 2021

Uh oh!

theopenlab-ci Bot commented Apr 30, 2021

Uh oh!

theopenlab-ci Bot commented May 13, 2021

Uh oh!

theopenlab-ci Bot commented May 17, 2021

Uh oh!

theopenlab-ci Bot commented May 17, 2021

Uh oh!

kzys left a comment

Choose a reason for hiding this comment

Uh oh!

samuelkarp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theopenlab-ci Bot commented Jun 1, 2021

Uh oh!

thaJeztah commented Jun 1, 2021

Uh oh!

theopenlab-ci Bot commented Jun 2, 2021

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci Bot commented Jun 3, 2021

Uh oh!

Reviewers

Assignees

claudiubelu commented Mar 30, 2021 •

edited

Loading