Skip to content

go.mod: github.com/containerd/fifo v1.0.0#5269

Merged
fuweid merged 1 commit intocontainerd:masterfrom
thaJeztah:update_fifo
Apr 19, 2021
Merged

go.mod: github.com/containerd/fifo v1.0.0#5269
fuweid merged 1 commit intocontainerd:masterfrom
thaJeztah:update_fifo

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 25, 2021

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Comment thread vendor/github.com/containerd/fifo/handle_nolinux.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 27, 2021

Build succeeded.

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/fifo v0.0.0-20210325135022-4614834762bf go.mod: github.com/containerd/fifo v0.0.0-20210330135133-a77444a26628 Mar 30, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 30, 2021

Build succeeded.

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/fifo v0.0.0-20210330135133-a77444a26628 go.mod: github.com/containerd/fifo v0.0.0-20210331061852-650e8a8a179d Mar 31, 2021
@thaJeztah thaJeztah marked this pull request as ready for review March 31, 2021 08:57
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 31, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

rebased, and changed to use tag v1.0.0 (same commit)

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/fifo v0.0.0-20210331061852-650e8a8a179d go.mod: github.com/containerd/fifo v1.0.0 Apr 19, 2021
@thaJeztah
Copy link
Copy Markdown
Member Author

@AkihiroSuda updated this one to v1.0.0 as well

*/

package sys
package fifo
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me comment on this change as it can be easily missed; this file has now been removed from sys/, and instead using the one from containerd/fifo

Screenshot 2021-04-19 at 09 31 24

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 19, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 93a602a into containerd:master Apr 19, 2021
@thaJeztah thaJeztah deleted the update_fifo branch April 19, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants