Skip to content

integration/util: remove dependency on k8s.io/klog/v2#5268

Merged
estesp merged 1 commit intocontainerd:masterfrom
thaJeztah:no_klog
Mar 25, 2021
Merged

integration/util: remove dependency on k8s.io/klog/v2#5268
estesp merged 1 commit intocontainerd:masterfrom
thaJeztah:no_klog

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 25, 2021

relates to microsoft/hcsshim#984

Having this log should not be critical, and removing it allows
using this package without pulling in the explicit dependency
on k8s.io/klog.

Having this log should not be critical, and removing it allows
using this package without pulling in the explicit dependency
on k8s.io/klog.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims March 25, 2021 14:42
Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Copy Markdown
Member

dims commented Mar 25, 2021

thanks @thaJeztah !

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 219f139 into containerd:master Mar 25, 2021
@thaJeztah thaJeztah deleted the no_klog branch March 25, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants