ctr: add --user for task exec#5266
Merged
estesp merged 1 commit intocontainerd:masterfrom Mar 25, 2021
Merged
Conversation
Member
Valid email address please |
AkihiroSuda
reviewed
Mar 25, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM but sign needs to be fixed
Contributor
Author
|
Sorry for not valid email address, and update commit |
AkihiroSuda
approved these changes
Mar 25, 2021
set user in exec container $ ctr t exec --exec-id e1 --user admin container id uid=500(admin) gid=500(admin) groups=500(admin) Signed-off-by: chuangxue <[email protected]> Signed-off-by: acetang <[email protected]>
Member
|
Merging as the one CI failure is a test timeout |
Contributor
Author
|
@estesp Thanks, I am weird this test run 238s, and I check other pr, not found same test in the passed ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set user in exec container
$ ctr t exec --exec-id e1 --user admin container id
uid=500(admin) gid=500(admin) groups=500(admin)
Signed-off-by: chuangxue [email protected]
Signed-off-by: acetang [email protected]