Run unit tests on CI for MacOS#5264
Merged
dmcgowan merged 2 commits intocontainerd:masterfrom Mar 25, 2021
Merged
Conversation
Though we don't officially support Apple platform, we should at least run unit tests to make sure things are not broken. Signed-off-by: Maksym Pavlenko <[email protected]>
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Maksym Pavlenko <[email protected]>
samuelkarp
reviewed
Mar 25, 2021
| import ( | ||
| "context" | ||
| "path/filepath" | ||
| goruntime "runtime" |
Member
There was a problem hiding this comment.
Elsewhere in the codebase this is aliased as "gruntime".
samuelkarp
approved these changes
Mar 25, 2021
Member
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
LGTM other than a naming suggestion
AkihiroSuda
approved these changes
Mar 25, 2021
thaJeztah
reviewed
Mar 25, 2021
| @@ -1,4 +1,4 @@ | |||
| // +build !windows | |||
| // +build !windows,!darwin | |||
Member
There was a problem hiding this comment.
Do you know what didn't work on Darwin for this?
Member
Author
There was a problem hiding this comment.
--- FAIL: TestBreakouts (9.18s)
--- FAIL: TestBreakouts/HardlinkSymlinkBeforeCreateTarget (8.78s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-027924874/localpasswd /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-027924874/localpasswd-dup: operation not permitted
--- FAIL: TestBreakouts/HardlinkSymlinkRelative (0.01s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-068255073/passwdlink /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-068255073/localpasswd: no such file or directory
--- FAIL: TestBreakouts/HardlinkSymlinkAbsolute (0.09s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-814375756/passwdlink /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-814375756/localpasswd: operation not permitted
FAIL
FAIL github.com/containerd/containerd/archive 13.724s
Member
Author
There was a problem hiding this comment.
I didn't dive in a lot what exactly is wrong here, for now I just want to enable tests in general.
We can follow up with this to run more tests.
kzys
approved these changes
Mar 25, 2021
dmcgowan
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though we don't officially support Macs, we should at least run unit tests
to make sure things are not broken on this platform.
Signed-off-by: Maksym Pavlenko [email protected]