Add CI job to cross compile all the things#5262
Conversation
cpuguy83
force-pushed
the
ci_cross_compile
branch
7 times, most recently
from
539088e to
508cbdd
Compare
This currently breaks armhf builds. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
ci_cross_compile
branch
from
508cbdd to
587b913
Compare
cpuguy83
force-pushed
the
ci_cross_compile
branch
2 times, most recently
from
545e0c7 to
27cbd58
Compare
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
LGTM, just some questions.
There was a problem hiding this comment.
Is 7 the lowest version of 32-bit Arm we want to support?
There was a problem hiding this comment.
We could add more and maybe worthwhile since I know folks use v5 and v6 with Docker.
There was a problem hiding this comment.
I'll also add windows+armv7 but this is known broken right now.
There was a problem hiding this comment.
@alexellis might have opinion on how "low" to go with arm 32-bit based on his connection to that community
There was a problem hiding this comment.
I'd suggest 6 is worth adding (that's Pi1 and Pi0, which are fairly popular), but even I'd consider 5 to be "best effort" (and not worth the CPU time to test explicitly).
(my 2¢)
There was a problem hiding this comment.
Oh, though cgo means armv6 is not something you'll be able to easily cross-compile from an Ubuntu environment unless you build/download a cross toolchain from elsewhere, so the most you could do is also add 5, which should cover the bases (if the 7 build works and a 5 build works, the odds of 6 having problems are really low -- they'd be toolchain mistakes, not code problems, at that point, like using the wrong C compiler 😄).
There was a problem hiding this comment.
And got the windows/arm/v7 build fixed as well (see go-winio update), so added that in.
There was a problem hiding this comment.
Also added linux/arm/v5, guess I didn't comment on that.
cpuguy83
force-pushed
the
ci_cross_compile
branch
from
27cbd58 to
60a3a9c
Compare
Signed-off-by: Brian Goff <[email protected]>
This makes sure we can compile on all the platforms and prevent things like integer overflows. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
ci_cross_compile
branch
from
60a3a9c to
311e326
Compare
|
This is very similar to what's happening in nightly build script. Should we consolidate them to maintain the code in one place? |
Maybe off-topic here, but I'd also like to see arm64 binaries to be available on https://github.com/containerd/containerd/releases |
|
@AkihiroSuda +1 and that has been requested since 2018 :) See #2901. |
9 participants
This makes sure we can compile on all the platforms and prevent things
like integer overflows.