Skip to content

remotes/ctr: allow to limit max concurrent uploads like downloads#5260

Merged
estesp merged 1 commit intocontainerd:masterfrom
fuweid:limit-concurent-uploads-when-push
Mar 25, 2021
Merged

remotes/ctr: allow to limit max concurrent uploads like downloads#5260
estesp merged 1 commit intocontainerd:masterfrom
fuweid:limit-concurent-uploads-when-push

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Mar 24, 2021

Also add flags for push/pull subcommand to limit max concurrent
uploads/downloads.

Signed-off-by: Wei Fu [email protected]

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a naming suggestion.

Comment thread client.go Outdated
@fuweid fuweid force-pushed the limit-concurent-uploads-when-push branch from f7c3e09 to 391ad5f Compare March 25, 2021 02:06
Comment thread cmd/ctr/commands/content/fetch.go Outdated
Copy link
Copy Markdown
Member

@mxpv mxpv Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is now very laconic :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Also add flags for push/pull subcommand to limit max concurrent
uploads/downloads.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid force-pushed the limit-concurent-uploads-when-push branch from 391ad5f to f8c2f04 Compare March 25, 2021 06:37
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4f7d1d7 into containerd:master Mar 25, 2021
@fuweid fuweid deleted the limit-concurent-uploads-when-push branch April 14, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants