task: allow checkpoint on pause state#5258
Merged
estesp merged 1 commit intocontainerd:masterfrom Mar 26, 2021
Merged
Conversation
Member
Author
fail case in windows-2019 |
task.Checkpoint should check status of container before handle checkpoint. If the container has been paused, task.Checkpoint should handle checkpoint and leave it paused. Signed-off-by: Wei Fu <[email protected]> Signed-off-by: Baijia <[email protected]>
fuweid
force-pushed
the
checkpoint-on-pause-state
branch
from
78339b5 to
72b7f4b
Compare
fuweid
changed the title
kzys
approved these changes
Mar 25, 2021
Contributor
|
Reasonable to check status before pause, LGTM |
Ace-Tang
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task.Checkpoint should check status of container before handle
checkpoint. If the container has been paused, task.Checkpoint should
handle checkpoint and leave it paused.
Signed-off-by: Wei Fu [email protected]
Signed-off-by: Baijia [email protected]