Make CRI registry docs more clear#5254
Conversation
|
Hi @voltbit. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mikebrow
left a comment
There was a problem hiding this comment.
see comments..
Note: commits have to be signed with a real name and email. Suggest using 'git commit -s --amend' after setting up your git config for name/email.
Cheers, Mike
There was a problem hiding this comment.
It would be ok to have a link to an archived v1 description for pre 1.3 users. We don't support moving a v2 config to the old syntax.
bf1af93 to
cb68cf3
Compare
|
Hey Mike, thanks for the comment, my commit is already signed with my personal email. You mean I should also add the 'Signed-off' message to my commit message? L.E. I've just read the CONTRIBUTING.md, applogies for not checking it first. I've added the text to my commit message. |
99363c6 to
e49effd
Compare
There was a problem hiding this comment.
believe it or not for this registry doc.. the 1.2 version was in continerd/cri .. over here:
https://github.com/containerd/cri/blob/release/1.2/docs/registry.md
sry about the DCO hassle :-) The reason I mentioned using Here's an example: note description is one line and fairly short; note blank line before and after signature... I didn't pull your commit header but it's usually one of those details... |
ddf1800 to
6cae3b6
Compare
Added reference to previous config syntax. Signed-off-by: Andrei Dobre <[email protected]>
6cae3b6 to
e4b9b10
Compare
|
Thanks! |
Added reference to previous config syntax.
Signed-off-by: Andrei Dobre [email protected]
Fixes #5151