Skip to content

night ci: add packages for ubuntu 20.04#5244

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
pacoxu:fix/night-run
Mar 22, 2021
Merged

night ci: add packages for ubuntu 20.04#5244
dmcgowan merged 1 commit intocontainerd:masterfrom
pacoxu:fix/night-run

Conversation

@pacoxu
Copy link
Copy Markdown
Contributor

@pacoxu pacoxu commented Mar 22, 2021

fixes #5240

@k8s-ci-robot
Copy link
Copy Markdown

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 22, 2021

Another two places using latest ubuntu are like below:

/Users/xupaco/git/gopath/src/k8s.io/containerd/.github/workflows/codeql.yml:
   19:     runs-on: ubuntu-latest

/Users/xupaco/git/gopath/src/k8s.io/containerd/.github/workflows/nightly.yml:
   12:     runs-on: ubuntu-latest

Comment thread .github/workflows/nightly.yml Outdated
Comment thread .github/workflows/nightly.yml Outdated
@pacoxu pacoxu force-pushed the fix/night-run branch 2 times, most recently from f25a4e6 to eadd82a Compare March 22, 2021 09:45
@pacoxu pacoxu changed the title use ubuntu-18.04 as the latest now is 20.04 night ci: add packages for ubuntu 20.04 Mar 22, 2021
@aojea
Copy link
Copy Markdown
Contributor

aojea commented Mar 22, 2021

LGTM

@AkihiroSuda
Copy link
Copy Markdown
Member

use ubuntu-18.04 as the latest now is 20.04

Could you fix the commit message (git commit -a -s --amend)? LGTM then.

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 22, 2021

@AkihiroSuda Done

@AkihiroSuda
Copy link
Copy Markdown
Member

Seems not: ac4a5b5

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 22, 2021

Fixed this time.
😳

@dmcgowan dmcgowan merged commit 4e919ff into containerd:master Mar 22, 2021
@thaJeztah thaJeztah added the cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch needs-ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly builds are broken

6 participants