Skip to content

Fix diff/walking.Compare file was not closed when an error occurred#5242

Closed
wzshiming wants to merge 1 commit intocontainerd:masterfrom
wzshiming:fix/diff-close
Closed

Fix diff/walking.Compare file was not closed when an error occurred#5242
wzshiming wants to merge 1 commit intocontainerd:masterfrom
wzshiming:fix/diff-close

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

Signed-off-by: Shiming Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmcgowan
Copy link
Copy Markdown
Member

@wzshiming can you describe the bug which you saw occur. err appears to have been used intentionally to avoid calling this cleanup code after Commit is called. If it is not cleaning up properly, that should be figured out first.

@wzshiming
Copy link
Copy Markdown
Contributor Author

@wzshiming can you describe the bug which you saw occur. err appears to have been used intentionally to avoid calling this cleanup code after Commit is called. If it is not cleaning up properly, that should be figured out first.

Ohhhh, I really didn’t expect this, thank you!

@wzshiming wzshiming closed this Mar 23, 2021
@wzshiming wzshiming deleted the fix/diff-close branch March 23, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants