Use specific image for user namespaces tests#5235
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Mar 20, 2021
Merged
Use specific image for user namespaces tests#5235AkihiroSuda merged 1 commit intocontainerd:masterfrom
AkihiroSuda merged 1 commit intocontainerd:masterfrom
Conversation
Due to the lack of an existing /proc dir in the rootfs of busybox, there seems to be a race between the mount of /proc and whether the root dir is already readonly? May need investigation, but for now use an image that has a /proc dir existing. Signed-off-by: Phil Estes <[email protected]>
Member
Author
|
Anyone who wants to dig deeper, you can reproduce with one or two runs of |
AkihiroSuda
approved these changes
Mar 20, 2021
samuelkarp
approved these changes
Mar 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the lack of an existing /proc dir in the rootfs of the busybox image, there
seems to be a race between the
mkdirprior to the mount of /proc and whetherthe root dir is already readonly? May need investigation, but for now use an image
that has a /proc dir existing.
Follow-on to comments in #5216 // cc @crosbymichael
Signed-off-by: Phil Estes [email protected]