Support HTTP debug in ctr#5234
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Mar 24, 2021
Merged
Conversation
Member
Author
|
Changes should not affect linux integration tests |
Member
Author
|
/ok-to-test |
samuelkarp
reviewed
Mar 20, 2021
Member
There was a problem hiding this comment.
Rather than accepting a transportWrapper, I think it might be more flexible for the resolver to accept a function that mutates an http.Client as an option. You could then pass the generated default http.Client to that function to get modified however the caller wishes.
type HTTPClientOptionFunc func(*http.Client) errorclient := &http.Client{
Transport: defaultTransport
}
if options.HTTPClientOption != nil {
if err := options.HTTPClientOption(client); err != nil {
return nil, err
}
}
Member
|
Sorry for the CI noise; #5235 will fix the failures in integration runs |
Signed-off-by: Maksym Pavlenko <[email protected]>
Member
Author
|
Updated and rebased. |
samuelkarp
approved these changes
Mar 23, 2021
Member
|
Thanks for this improvement @mxpv! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
http-dumpflag can dump HTTP request/responses when interacting with container registry.http-traceis Enable Go HTTP tracing of registry interactions #5040 follow upSigned-off-by: Maksym Pavlenko [email protected]