[release/1.4] backport: Support adding devices by dir#5232
Closed
cpuguy83 wants to merge 1 commit intocontainerd:release/1.4from
Closed
[release/1.4] backport: Support adding devices by dir#5232cpuguy83 wants to merge 1 commit intocontainerd:release/1.4from
cpuguy83 wants to merge 1 commit intocontainerd:release/1.4from
Conversation
Member
Author
|
Oh I guess I need to |
estesp
changed the title
Member
|
@cpuguy83 yeah. backport to release/1.4, vendor into containerd/cri and then vendor back into release/1.4 😂 |
This enables cases where devices exist in a subdirectory of /dev, particularly where those device names are not portable across machines, which makes it problematic to specify from a runtime such as cri. Added this to `ctr` as well so I could test that the code at least works. -- This commit is slightly modifified from the original due to cri vendoring. Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 7776e5e) Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
1.4_devices_by_dir
branch
from
505581a to
3bdff0c
Compare
Member
Author
|
Updated this to remove vendor changes. |
kzys
approved these changes
May 27, 2021
Member
dmcgowan
approved these changes
Jul 27, 2021
Member
Author
|
I think this is too risky to take in such a late stage for 1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables cases where devices exist in a subdirectory of /dev,
particularly where those device names are not portable across machines,
which makes it problematic to specify from a runtime such as cri.
Added this to
ctras well so I could test that the code at leastworks.
This is a backport of #4847 which is fixing a problem for us where Docker supports devices by path, but the same pod spec on containerd errors out.