Skip to content

Fix error log when copy file#5229

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
wzshiming:fix/log-cp-file
Mar 19, 2021
Merged

Fix error log when copy file#5229
dmcgowan merged 1 commit intocontainerd:masterfrom
wzshiming:fix/log-cp-file

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

@wzshiming wzshiming commented Mar 19, 2021

Signed-off-by: Shiming Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 19, 2021

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming wzshiming mentioned this pull request Mar 19, 2021
Merged
mikebrow
mikebrow approved these changes Mar 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Mar 19, 2021

/ok-to-test

dmcgowan
dmcgowan reviewed Mar 19, 2021
View reviewed changes
Comment thread pkg/process/init.go Outdated
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more consistent log would probably be log.G(ctx).WithError(cerr).Error("failed to copy dump.log to criu-dump.log")

@wzshiming
Fix error log when copy file
1410220 
Signed-off-by: Shiming Zhang <[email protected]>
@dmcgowan dmcgowan merged commit 0d569f8 into containerd:master Mar 19, 2021
@wzshiming wzshiming deleted the fix/log-cp-file branch March 19, 2021 18:02
fuweid added a commit that referenced this pull request Mar 27, 2021
@fuweid
Merge pull request #5231 from wzshiming/cherry-pick/upstream/release/…
1322c70 
…1.4/#5229

[release/1.4] Cherry pick of #5229: Fix error log when copy file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

kind/bug ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wzshiming @k8s-ci-robot @mikebrow @kzys @dmcgowan @AkihiroSuda