Skip to content

change default runtime for containerd-stress app#5218

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
alakesh:runtime-v2-stress
Mar 18, 2021
Merged

change default runtime for containerd-stress app#5218
crosbymichael merged 1 commit intocontainerd:masterfrom
alakesh:runtime-v2-stress

Conversation

@alakesh
Copy link
Copy Markdown
Contributor

@alakesh alakesh commented Mar 17, 2021

This fixes following warning message by changing the default runtime
to io.containerd.runc.v2 and does not require user to set the runtime
from command line anymore.

"WARN[2021-03-17T21:11:01.441207858Z] runtime v1 is deprecated since
containerd v1.4, consider using runtime v2"

Signed-off-by: Alakesh Haloi [email protected]

This fixes following warning message by changing the default runtime
to io.containerd.runc.v2 and does not require user to set the runtime
from command line anymore.

"WARN[2021-03-17T21:11:01.441207858Z] runtime v1 is deprecated since
containerd v1.4, consider using runtime v2"

Signed-off-by: Alakesh Haloi <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @alakesh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kzys
Copy link
Copy Markdown
Member

kzys commented Mar 17, 2021

/ok-to-test

@crosbymichael crosbymichael merged commit 31c0587 into containerd:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants