Skip to content

go.mod: github.com/containerd/typeurl v1.0.2#5213

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_typeurl
Apr 14, 2021
Merged

go.mod: github.com/containerd/typeurl v1.0.2#5213
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_typeurl

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 16, 2021

full diff: containerd/typeurl@v1.0.1...v1.0.2

  • Fix lock for getTypeByUrl

no significant other changes, other than getting rid of github.com/gogo/protobuf v1.3.1 in the go mod tree

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2021

Build succeeded.

@dims
Copy link
Copy Markdown
Member

dims commented Mar 17, 2021

@thaJeztah yea, let's make sure the containerd 1.5.0 RC has tagged versions, if we really don't need to ... then we can wait to get this in

@thaJeztah
Copy link
Copy Markdown
Member Author

@thaJeztah yea, let's make sure the containerd 1.5.0 RC has tagged versions, if we really don't need to ... then we can wait to get this in

Yes, I had a draft 'note' / working on a list of dependencies that have tagged release, but for which we're currently using versions from "tip" that we should tag (or request to be tagged) before GA

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/typeurl v1.0.2-0.20210316200855-63e572db4ddb go.mod: github.com/containerd/typeurl v1.0.2-0.20210318032713-5e43fb8b75ed Apr 6, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 6, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

rebased to trigger CI (which should now be fixed)

@thaJeztah
Copy link
Copy Markdown
Member Author

Interesting; new failure in script validation?

==> default: Checking if box 'fedora/33-cloud-base' version '33.20201019.0' is up to date...
==> default: Running provisioner: install-runc (shell)...
    default: Running: inline script
    default: /tmp/vagrant-install-runc: line 5: GOPATH: unbound variable
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 7, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 7, 2021

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

v1.0.2 is tagged, update

@thaJeztah
Copy link
Copy Markdown
Member Author

Updated; I also removed the second commit that tried to fix the runc installation - as I'm wondering if it was just a flaky (if it's failing again, I'll add it back)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/typeurl v1.0.2-0.20210318032713-5e43fb8b75ed go.mod: github.com/containerd/typeurl v1.0.2 Apr 13, 2021
@thaJeztah
Copy link
Copy Markdown
Member Author

Network Project: cri-c8d-pr-node-e2e
Zone: us-central1-f
Dumping logs from master locally to '/logs/artifacts'
Trying to find master named 'bootstrap-e2e-master'
Looking for address 'bootstrap-e2e-master-ip'
ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
 - The resource 'projects/cri-c8d-pr-node-e2e/regions/us-central1/addresses/bootstrap-e2e-master-ip' was not found

@thaJeztah
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@dmcgowan dmcgowan merged commit c381ea2 into containerd:master Apr 14, 2021
@thaJeztah thaJeztah deleted the bump_typeurl branch April 14, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants