Skip to content

gofmt -s -w all the things#5212

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:gofmt_all_the_things
Mar 17, 2021
Merged

gofmt -s -w all the things#5212
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:gofmt_all_the_things

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

gofmt_all_the_things

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2021

Build succeeded.

@kzys
Copy link
Copy Markdown
Member

kzys commented Mar 16, 2021

The change itself looks good. Can we run go fmt -s -w on GitHub Actions or somewhere and make sure that no files are modified by that?

@thaJeztah
Copy link
Copy Markdown
Member Author

Can we run go fmt -s -w on GitHub Actions or somewhere and make sure that no files are modified by that?

I think we should; was actually surprised that (apparently?) it didn't do so yet. Perhaps something to add to our "projects" github action

Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 5978fe8 into containerd:master Mar 17, 2021
@thaJeztah thaJeztah deleted the gofmt_all_the_things branch March 17, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants