Skip to content

go.mod: github.com/containerd/continuity v0.0.0-20210315143101-93e15499afd5#5209

Closed
thaJeztah wants to merge 1 commit intocontainerd:masterfrom
thaJeztah:bump_continuity
Closed

go.mod: github.com/containerd/continuity v0.0.0-20210315143101-93e15499afd5#5209
thaJeztah wants to merge 1 commit intocontainerd:masterfrom
thaJeztah:bump_continuity

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 16, 2021

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2021

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 16, 2021

let me rebase; #5207 was merged, and conflicted in go.mod

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 16, 2021

rebased 👍

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 16, 2021

Some failure on Windows (could be flaky); posting the start of that dump, in case it's interesting (could be related to the Go 1.14+ changes??)

Exception 0xc0000420 0x0 0x0 0x7fff05c12e0a
PC=0x7fff05c12e0a
signal arrived during external code execution

syscall.Syscall(0x7ffefc18d430, 0x2, 0x171df80, 0xc000f58460, 0x0, 0x0, 0x0, 0x0)
	C:/hostedtoolcache/windows/go/1.16.2/x64/src/runtime/syscall_windows.go:330 +0xe9
github.com/Microsoft/hcsshim/internal/wclayer._destroyLayer(0x171df80, 0xc000f58460, 0xc000f58460, 0x26)
	D:/a/containerd/containerd/pkg/mod/github.com/!microsoft/[email protected]/internal/wclayer/zsyscall_windows.go:236 +0x179
github.com/Microsoft/hcsshim/internal/wclayer.destroyLayer(0x171df80, 0xc001c21cb0, 0x25, 0x1, 0x0)
	D:/a/containerd/containerd/pkg/mod/github.com/!microsoft/[email protected]/internal/wclayer/zsyscall_windows.go:229 +0xbc
github.com/Microsoft/hcsshim/internal/wclayer.DestroyLayer(0x1a988d8, 0xc0000a0118, 0xc001c21cb0, 0x25, 0x0, 0x0)
	D:/a/containerd/containerd/pkg/mod/github.com/!microsoft/[email protected]/internal/wclayer/destroylayer.go:20 +0x205
github.com/Microsoft/hcsshim.DestroyLayer(0x0, 0xc000221c20, 0x1b, 0xc00025a7fc, 0x9, 0xc000f5a3e0, 0xc0000fc000)
	D:/a/containerd/containerd/pkg/mod/github.com/!microsoft/[email protected]/layer.go:34 +0xe5
github.com/containerd/containerd/sys.ForceRemoveAll(0xc00025a7e0, 0x25, 0xc000f5a3e0, 0x192062c)
	D:/a/containerd/containerd/src/github.com/containerd/containerd/sys/filesys_windows.go:267 +0xaf
github.com/containerd/containerd/integration/client.TestMain(0xc0003d4180)
	D:/a/containerd/containerd/src/github.com/containerd/containerd/integration/client/client_test.go:169 +0xc88
main.main()
	_testmain.go:155 +0x272

@thaJeztah thaJeztah closed this Mar 16, 2021
@thaJeztah thaJeztah reopened this Mar 16, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2021

Build succeeded.

@pacoxu pacoxu mentioned this pull request Mar 23, 2021
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2021

Build succeeded.

@thaJeztah thaJeztah mentioned this pull request Apr 12, 2021
Closed
14 tasks
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Apr 13, 2021

Closing this one, no functional changes

@dmcgowan dmcgowan closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @dmcgowan @Zyqsempai @AkihiroSuda