Skip to content

move overlay-checks to an overlayutils package#5204

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:overlayutils
Mar 16, 2021
Merged

move overlay-checks to an overlayutils package#5204
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:overlayutils

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This allows using the utilities without importing the whole snapshotter.

relates to the discussion on moby/moby#42068 (comment). This potentially allows moby to use this package, instead of maintaining the moby overlayutils package

This allows using the utilities without importing the whole
snapshotter.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

@AkihiroSuda @estesp @dmcgowan ptal

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 15, 2021

🤔 perhaps needs some minor refactoring after to remove the log import (instead allowing a logger to be passed 🤔)

edit: would it be acceptable for these log messages to use logrus instead of containerd/log.L ?
edit2: looks like that's already used in many places, so probably doesn't make a difference

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

Windows failure is unrelated. Merging.

@AkihiroSuda AkihiroSuda merged commit fef6bb8 into containerd:master Mar 16, 2021
@thaJeztah thaJeztah deleted the overlayutils branch March 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants