Change dgst to digest in debug#5202
Conversation
Signed-off-by: Shiming Zhang <[email protected]>
|
Hi @wzshiming. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
These messages are not visible to users, so I don't think this change is necessary
|
But some are |
|
@AkihiroSuda These messages are not visible for users who call containerd, but they are visible for users who operate containerd. Unifying logrus attributes makes investigating operational issues easier. |
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
This could be helpful for tracing a specific digest in the logs using the same key
|
@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test Can I trigger that? :) |
7 participants
Signed-off-by: Shiming Zhang [email protected]