Skip to content

ctr plugin ls: plugin status should be skip, not error#5200

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
pacoxu:skip-error-check
Mar 16, 2021
Merged

ctr plugin ls: plugin status should be skip, not error#5200
crosbymichael merged 1 commit intocontainerd:masterfrom
pacoxu:skip-error-check

Conversation

@pacoxu
Copy link
Copy Markdown
Contributor

@pacoxu pacoxu commented Mar 15, 2021 

[root@daocloud ~]# ctr plugin ls
TYPE                            ID                       PLATFORMS      STATUS
io.containerd.content.v1        content                  -              ok
io.containerd.snapshotter.v1    aufs                     linux/amd64    error
io.containerd.snapshotter.v1    devmapper                linux/amd64    error
io.containerd.snapshotter.v1    native                   linux/amd64    ok
io.containerd.snapshotter.v1    overlayfs                linux/amd64    ok
io.containerd.snapshotter.v1    zfs                      linux/amd64    error

Type:          io.containerd.snapshotter.v1
ID:            zfs
Platforms:     linux/amd64
Exports:
               root      /var/lib/containerd/io.containerd.snapshotter.v1.zfs
Error:
               Code:        Unknown
               Message:     path /var/lib/containerd/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter: skip plugin

Skip error can be identified as skip
/kind bug

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 15, 2021

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@pacoxu pacoxu force-pushed the skip-error-check branch from cfc678c to 8d3b432 Compare March 15, 2021 08:45
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@pacoxu pacoxu force-pushed the skip-error-check branch from 8d3b432 to cc2652d Compare March 15, 2021 08:58
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@pacoxu pacoxu force-pushed the skip-error-check branch from cc2652d to 621577b Compare March 15, 2021 09:50
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@pacoxu pacoxu force-pushed the skip-error-check branch from 621577b to a76cefd Compare March 15, 2021 10:04
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2021

Build succeeded.

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 15, 2021

/retest

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 15, 2021

@pacoxu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 15, 2021 •
edited
Loading

Mon, 15 Mar 2021 10:23:35 GMT exit status 3221226528
Mon, 15 Mar 2021 10:23:35 GMT FAIL github.com/containerd/containerd/integration/client 358.217s
Mon, 15 Mar 2021 10:23:35 GMT mingw32-make: *** [Makefile:181: integration] Error 1
Mon, 15 Mar 2021 10:23:35 GMTError: Process completed with exit code 2.

CI / Windows Integration (pull_request) failed for the above error message. It seems to be a timeout?

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Mar 16, 2021 •
edited
Loading

@samuelkarp
What can I do for Failed Windows Integration?
retest or force update?

@crosbymichael crosbymichael merged commit 1a28c2f into containerd:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@crosbymichael crosbymichael crosbymichael approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pacoxu @k8s-ci-robot @samuelkarp @crosbymichael @AkihiroSuda