Skip to content

Improve unexpected response error handling#5164

Merged
estesp merged 2 commits intocontainerd:masterfrom
errordeveloper:master
Mar 14, 2021
Merged

Improve unexpected response error handling#5164
estesp merged 2 commits intocontainerd:masterfrom
errordeveloper:master

Conversation

@errordeveloper
Copy link
Copy Markdown
Contributor

No description provided.

This should help with debugging expected responses.

Signed-off-by: Ilya Dmitrichenko <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @errordeveloper. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 92009ad into containerd:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants