Skip to content

deflake TestRestartMonitor#5157

Merged
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:deflake-TestRestartMonitor
Mar 11, 2021
Merged

deflake TestRestartMonitor#5157
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:deflake-TestRestartMonitor

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Mar 11, 2021

Fix #5146

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 11, 2021
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Mar 11, 2021

CI failure is unrelated

Run vagrant up --provision-with=selinux,install-runc,test-integration
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'fedora/33-cloud-base' version '33.20201019.0' is up to date...
==> default: Running provisioner: install-runc (shell)...
    default: Running: inline script
    default: /tmp/vagrant-install-runc: line 5: GOPATH: unbound variable

https://github.com/containerd/containerd/pull/5157/checks?check_run_id=2083879992

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 11, 2021

@AkihiroSuda: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-containerd-node-e2e ee84e85 link /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Zyqsempai
Zyqsempai approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 8634cd9 into containerd:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky Test: TestRestartMonitor

4 participants

@AkihiroSuda @k8s-ci-robot @estesp @Zyqsempai