Skip to content

CI: Add a name for the vagrant up step#5156

Merged
fuweid merged 1 commit intocontainerd:masterfrom
estesp:step-name
Mar 11, 2021
Merged

CI: Add a name for the vagrant up step#5156
fuweid merged 1 commit intocontainerd:masterfrom
estesp:step-name

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Mar 10, 2021

Without a name the logs use a carriage return followed by the long
comment ("# Retry if it fails"...) as the name of the job step which is messy when working with the
actions API/logs.

Signed-off-by: Phil Estes [email protected]

Without a name the logs use a carriage return followed by the long
comment as the name of the job step which is messy when working with the
actions API/logs.

Signed-off-by: Phil Estes <[email protected]>
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 10, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 2b1e913 into containerd:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants