Better error when handling a descriptor of size zero#5154
Merged
mxpv merged 1 commit intocontainerd:masterfrom Mar 14, 2021
Merged
Better error when handling a descriptor of size zero#5154mxpv merged 1 commit intocontainerd:masterfrom
mxpv merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
|
Sure, I should be able to use an old version of Trow. I can use the binary in |
Member
Author
|
What is |
mxpv
approved these changes
Mar 10, 2021
kzys
approved these changes
Mar 10, 2021
dmcgowan
reviewed
Mar 10, 2021
Signed-off-by: Phil Estes <[email protected]>
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5124
Any chance you have a way to try this fix @amouat? I am only able to force this error with a contrived setup that just forces the size to zero earlier in the code flow from a pull operation.
Signed-off-by: Phil Estes [email protected]