Fix error checking when resolving shim binary path#5143
Merged
fuweid merged 1 commit intocontainerd:masterfrom Mar 9, 2021
Merged
Fix error checking when resolving shim binary path#5143fuweid merged 1 commit intocontainerd:masterfrom
fuweid merged 1 commit intocontainerd:masterfrom
Conversation
Previously a typo was introduced that caused the wrong error to be checked against when calling exec.LookPath. This had the effect that containerd would never locate the shim binary if it was in the same directory as containerd's binary, but not in PATH. Signed-off-by: Kevin Parsons <[email protected]>
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a typo was introduced that caused the wrong error to be
checked against when calling exec.LookPath. This had the effect that
containerd would never locate the shim binary if it was in the same
directory as containerd's binary, but not in PATH.
Signed-off-by: Kevin Parsons [email protected]