Skip to content

adds a new install-deps in the makefile; and some refactoring of the scripts#5132

Merged
mikebrow merged 3 commits intocontainerd:masterfrom
mikebrow:add-some-debug-out-for-dep-setups
Mar 24, 2021
Merged

adds a new install-deps in the makefile; and some refactoring of the scripts#5132
mikebrow merged 3 commits intocontainerd:masterfrom
mikebrow:add-some-debug-out-for-dep-setups

Conversation

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow mikebrow commented Mar 5, 2021

More work here for the migration from containerd/cri to containerd/containerd

enables CRI testing on local development boxes...

Signed-off-by: Mike Brown [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 5, 2021

Build succeeded.

Comment thread Makefile Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 9, 2021

Build succeeded.

@mikebrow mikebrow force-pushed the add-some-debug-out-for-dep-setups branch from a2adfb0 to 98471c2 Compare March 10, 2021 21:22
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 10, 2021

Build succeeded.

@mikebrow mikebrow force-pushed the add-some-debug-out-for-dep-setups branch from 98471c2 to 2205da6 Compare March 11, 2021 16:24
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2021

Build succeeded.

@mikebrow mikebrow changed the title adds a new install-deps in the makefile; and some debug out adds a new install-deps in the makefile; and some refactoring of the scripts Mar 11, 2021
@mikebrow mikebrow requested a review from thaJeztah March 11, 2021 17:07
@mikebrow
Copy link
Copy Markdown
Member Author

@thaJeztah refactored how the cri-tools version is changed the same way you refactored for runc-version

Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread script/setup/critools-version Outdated
Comment thread Makefile Outdated
Signed-off-by: Mike Brown <[email protected]>
@mikebrow mikebrow force-pushed the add-some-debug-out-for-dep-setups branch from bbea0e8 to 9ad87b9 Compare March 24, 2021 15:59
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice!

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 548d984 into containerd:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants