Print elapsed time for image unpack#5114
Conversation
|
Hi @alakesh. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
There was a problem hiding this comment.
How do you feel about:
| fmt.Printf("done: %-4.1fs\t\n", time.Since(start).Seconds()) | |
| fmt.Printf("done: %s\t\n", time.Since(start)) |
So it'll choose proper formatting depending on elapsed time:
done: 10s
done: 1m40s
done: 2h46m40s
There was a problem hiding this comment.
Thanks for the suggestion. It definitely looks better even though just using seconds makes it more script friendly. Updated the PR.
alakesh
force-pushed
the
print-unpack-time
branch
from
a0b2ace to
b4f9565
Compare
|
Build succeeded.
|
alakesh
force-pushed
the
print-unpack-time
branch
from
b4f9565 to
513a9cf
Compare
|
Build succeeded.
|
alakesh
force-pushed
the
print-unpack-time
branch
from
513a9cf to
3c60a41
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
The provides additional insight into how much time is being spent in unpacking and is helpful in performance comparison for just this stage without resorting to running under time command in linux for example. Signed-off-by: Alakesh Haloi <[email protected]>
alakesh
force-pushed
the
print-unpack-time
branch
from
3c60a41 to
9f5244f
Compare
|
Build succeeded.
|
5 participants
This provides additional insight into how much time is being spent in
unpacking and is helpful in performance comparison for just this stage
without resorting to running under time command in linux for example.
Signed-off-by: Alakesh Haloi [email protected]