mark device faulty after parent fails to suspend#5111
mark device faulty after parent fails to suspend#5111crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @ctrlaltdel121. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Could you please sign off your commits (try |
|
Build succeeded.
|
When an error is returned here, unlike the other error returns in the function, nothing is done to mark the added device as faulty or remove it. I have observed this causing future snapshot creations to continue to attempt to use the same ID (from the sequence) to create new devices and get blocked because the device already exists because it was not rolled back here. Hopefully fixes containerd#5110 Signed-off-by: Jeremy Williams <[email protected]>
|
Build succeeded.
|
4 participants
When an error is returned here, unlike the other error returns in the function, nothing is done to mark the added device as faulty or remove it.
I have observed this causing future snapshot creations to continue to attempt to use the same ID (from the sequence) to create new devices and get blocked because the device already exists because it was not rolled back here.
Hopefully fixes #5110