Skip to content

Skip TLS verification for localhost#5100

Merged
estesp merged 1 commit intocontainerd:masterfrom
adisky:skip-tls-localHost
May 12, 2021
Merged

Skip TLS verification for localhost#5100
estesp merged 1 commit intocontainerd:masterfrom
adisky:skip-tls-localHost

Conversation

@adisky
Copy link
Copy Markdown
Contributor

@adisky adisky commented Mar 1, 2021 •
edited
Loading

Signed-off-by: Aditi Sharma [email protected]
#4826

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 1, 2021

Hi @adisky. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adisky adisky mentioned this pull request Mar 1, 2021
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 1, 2021

Build succeeded.

AkihiroSuda
AkihiroSuda reviewed Mar 1, 2021
View reviewed changes
Comment thread pkg/cri/server/image_pull.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 3, 2021

Build succeeded.

@adisky adisky force-pushed the skip-tls-localHost branch from 2165743 to 30a15be Compare March 3, 2021 06:52
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 3, 2021

Build succeeded.

@adisky adisky force-pushed the skip-tls-localHost branch from 30a15be to 5eee8b6 Compare March 3, 2021 09:01
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 3, 2021

Build succeeded.

@adisky adisky changed the title [WIP] Skip TLS verification for localhost Skip TLS verification for localhost Mar 3, 2021
@adisky
Copy link
Copy Markdown
Contributor Author

adisky commented Mar 3, 2021

not related testing this job
/test pull-containerd-node-e2e

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 3, 2021

@adisky: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

not related testing this job
/test pull-containerd-node-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Copy Markdown
Member

dims commented Mar 3, 2021

/ok-to-test

@adisky
Copy link
Copy Markdown
Contributor Author

adisky commented Mar 3, 2021 •
edited
Loading

(not related)
/test pull-containerd-node-e2e

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 6, 2021
Closed
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 19, 2021

/test pull-containerd-node-e2e

@AkihiroSuda AkihiroSuda reopened this Apr 19, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 19, 2021

Build succeeded.

estesp
estesp approved these changes Apr 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow reviewed Apr 19, 2021
View reviewed changes
Comment thread pkg/cri/server/image_pull.go Outdated
mikebrow
mikebrow reviewed Apr 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a nit where we could return true when host == "localhost"

@adisky adisky force-pushed the skip-tls-localHost branch from 5eee8b6 to 8014d9f Compare May 3, 2021 04:53
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 3, 2021

Build succeeded.

@adisky
Copy link
Copy Markdown
Contributor Author

adisky commented May 3, 2021

@mikebrow Updated!!!

@estesp estesp merged commit e47400c into containerd:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan left review comments

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@mikebrow mikebrow mikebrow left review comments

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adisky @k8s-ci-robot @dims @AkihiroSuda @dmcgowan @estesp @mikebrow