Skip to content

update linuxkit readme#5088

Merged
estesp merged 1 commit intocontainerd:masterfrom
Iceber:update-linuxkit-readme
Mar 1, 2021
Merged

update linuxkit readme#5088
estesp merged 1 commit intocontainerd:masterfrom
Iceber:update-linuxkit-readme

Conversation

@Iceber
Copy link
Copy Markdown
Member

@Iceber Iceber commented Feb 25, 2021

Although linuxkit/kubernetes has not been updated for a long time

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 25, 2021

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Iceber Iceber force-pushed the update-linuxkit-readme branch from 99b2390 to eefb949 Compare February 25, 2021 19:37
@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Feb 25, 2021

/ok-to-test

mikebrow
mikebrow reviewed Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggested edits

Comment thread contrib/linuxkit/README.md Outdated
Copy link
Copy Markdown
Member

@mikebrow mikebrow Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:

The [LinuxKit](https://github.com/linuxkit/kubernetes) is a project for building os images for kubernetes master and worker node virtual machines.

Comment thread contrib/linuxkit/README.md Outdated
Copy link
Copy Markdown
Member

@mikebrow mikebrow Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:

When the images are built with cri-containerd as the KUBE_RUNTIME option they will use `cri-containerd` as their execution backend.

@Iceber Iceber force-pushed the update-linuxkit-readme branch from eefb949 to a3e20a3 Compare February 26, 2021 01:58
@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Feb 26, 2021

@mikebrow updated. Thanks

@Iceber Iceber requested a review from mikebrow February 26, 2021 02:00
@Iceber Iceber closed this Feb 26, 2021
@Iceber Iceber reopened this Feb 26, 2021
@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Feb 26, 2021

/retest

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 26, 2021

Build succeeded.

@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Feb 26, 2021

/retest

@Iceber Iceber force-pushed the update-linuxkit-readme branch from a3e20a3 to cf559f8 Compare February 26, 2021 08:02
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 26, 2021

Build succeeded.

@Iceber
update linuxkit readme
ba19912 
Signed-off-by: Iceber Gu <[email protected]>
@Iceber Iceber force-pushed the update-linuxkit-readme branch from cf559f8 to ba19912 Compare March 1, 2021 04:01
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 1, 2021

Build succeeded.

fuweid
fuweid approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 54a63a3 into containerd:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

@mikebrow mikebrow Awaiting requested review from mikebrow

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Iceber @k8s-ci-robot @mikebrow @estesp @fuweid