Skip to content

Fix broken docs links#5085

Merged
mikebrow merged 3 commits intocontainerd:masterfrom
alexyadon:fix-broken-docs-links
Feb 25, 2021
Merged

Fix broken docs links#5085
mikebrow merged 3 commits intocontainerd:masterfrom
alexyadon:fix-broken-docs-links

Conversation

@alexyadon
Copy link
Copy Markdown
Contributor

@alexyadon alexyadon commented Feb 25, 2021

I came across some broken links in the docs. Looks like relative paths that were not updated when stuff was moved to a different folder. I went through the docs folder and fixed all where I could find what they were meant to be linking to.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 25, 2021

Hi @alexyadon. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mikebrow
mikebrow reviewed Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Comment thread docs/PLUGINS.md Outdated
Comment thread docs/RUNC.md Outdated
Comment thread docs/cri/installation.md Outdated
Comment thread docs/cri/testing.md Outdated
@alexyadon
docs: use relative paths
d999db0 
Signed-off-by: Alex Yadon <[email protected]>
@alexyadon
Copy link
Copy Markdown
Contributor Author

alexyadon commented Feb 25, 2021

Thanks @mikebrow. Wasn't sure if relative paths or paths from root would be preferred. I've updated per your suggestions.

mikebrow
mikebrow approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit c61f0ce into containerd:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexyadon @k8s-ci-robot @mikebrow