Skip to content

Prepare 1.5.0-beta.2 release#5080

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:prepare-1.5.0-beta.2
Feb 26, 2021
Merged

Prepare 1.5.0-beta.2 release#5080
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:prepare-1.5.0-beta.2

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Updates release notes, version, and mailmap for 1.5.0-beta.2

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a nit

Comment thread releases/v1.5.0-beta.toml
* **Optimize LCOW snapshotter use of scratch layers** [#4643](https://github.com/containerd/containerd/pull/4643)

## CRI
* **Update privileged containers to use current capabilities instead of known capabilities** [#5017](https://github.com/containerd/containerd/pull/5017)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specific to CRI

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you suggest here? Trying to limit the categorization in the release notes since we don't normally include library level changes or ctr. The most user impactful part here I think is CRI

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't normally include library level changes

I think we should make an exceptional case here to have "Library changes" section, because now the caller of oci.WithPrivileged needs to be as privileged as possible

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we aren't limited to this format either. I try to keep this list short and sweet, but in the past we have included more detail. We can further detail the impactful changes as part of this release. This is certainly not the only big change for clients in this release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to add a section to the 1.5.0 release notes at any time and we will get into the next beta/rc. I'll try to think about more content we can add there as well.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 24, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
with one minor comment

Comment thread releases/v1.5.0-beta.toml
## Windows
* **Optimize LCOW snapshotter use of scratch layers** [#4643](https://github.com/containerd/containerd/pull/4643)

## CRI
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest OCI for this item

@dmcgowan dmcgowan merged commit 07a3ce3 into containerd:master Feb 26, 2021
@dmcgowan dmcgowan deleted the prepare-1.5.0-beta.2 branch March 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants