Skip to content

FIx file is not closed#5045

Merged
estesp merged 1 commit intocontainerd:masterfrom
wzshiming:fix/file-not-closed
Feb 18, 2021
Merged

FIx file is not closed#5045
estesp merged 1 commit intocontainerd:masterfrom
wzshiming:fix/file-not-closed

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

@wzshiming wzshiming commented Feb 18, 2021

Signed-off-by: Shiming Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 18, 2021

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2021

Build succeeded.

@wzshiming wzshiming changed the title File is not closed FIx file is not closed Feb 18, 2021
AkihiroSuda
AkihiroSuda reviewed Feb 18, 2021
View reviewed changes
Comment thread mount/losetup_linux.go Outdated
fuweid
fuweid reviewed Feb 18, 2021
View reviewed changes
Comment thread mount/losetup_linux.go
@wzshiming wzshiming force-pushed the fix/file-not-closed branch 2 times, most recently from ebcda17 to 7081d1c Compare February 18, 2021 08:48
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2021

Build succeeded.

@wzshiming
Copy link
Copy Markdown
Contributor Author

wzshiming commented Feb 18, 2021

/retest

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 18, 2021

@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fuweid
fuweid reviewed Feb 18, 2021
View reviewed changes
Comment thread mount/losetup_linux.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2021

Build succeeded.

@wzshiming
Fix file is not closed
5e4acc0 
Signed-off-by: Shiming Zhang <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2021

Build succeeded.

cpuguy83
cpuguy83 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit d30a6c0 into containerd:master Feb 18, 2021
@wzshiming wzshiming deleted the fix/file-not-closed branch February 19, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid left review comments

@kzys kzys kzys approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wzshiming @k8s-ci-robot @kzys @cpuguy83 @mxpv @estesp @AkihiroSuda @fuweid