Skip to content

Fix TestRuntimeHandler logging#5033

Merged
estesp merged 1 commit intocontainerd:masterfrom
chrisfregly:master
Feb 18, 2021
Merged

Fix TestRuntimeHandler logging#5033
estesp merged 1 commit intocontainerd:masterfrom
chrisfregly:master

Conversation

@chrisfregly
Copy link
Copy Markdown

@chrisfregly chrisfregly commented Feb 12, 2021

Resolving issue #5032:

  • An empty --runtime-handler flag results in testing against the default runtime so modified and removed logging to clarify.
  • Added a TODO for future work on potentially adding test(s) for multiple runtimes at the same time.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 12, 2021

Hi @chrisfregly. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 12, 2021

Build succeeded.

@chrisfregly
Copy link
Copy Markdown
Author

chrisfregly commented Feb 15, 2021

/cc @mikebrow

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Feb 15, 2021

/ok-to-test

mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Comment thread integration/runtime_handler_test.go Outdated
mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Comment thread integration/runtime_handler_test.go Outdated
mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Comment thread integration/runtime_handler_test.go Outdated
Copy link
Copy Markdown
Member

@mikebrow mikebrow Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`runtimeService.ListPodSandbox() returns...'

Copy link
Copy Markdown
Author

@chrisfregly chrisfregly Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above ^

mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, thx.

mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Comment thread integration/runtime_handler_test.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 16, 2021

Build succeeded.

4 similar comments
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 16, 2021

Build succeeded.

mikebrow
mikebrow approved these changes Feb 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Feb 18, 2021

@chrisfregly would you squash commits? The change is small. Thanks

fix: issue #5032
80e1d98 
Signed-off-by: Chris Fregly <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2021

Build succeeded.

@chrisfregly
Copy link
Copy Markdown
Author

chrisfregly commented Feb 18, 2021

Commits have been squashed. Thanks for reviewing

estesp
estesp approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a98c83c into containerd:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chrisfregly @k8s-ci-robot @mikebrow @fuweid @cpuguy83 @estesp