Skip to content

[cri] add pod annotations to CNI call#5026

Merged
mikebrow merged 1 commit intocontainerd:masterfrom
crosbymichael:cni-anno
Feb 10, 2021
Merged

[cri] add pod annotations to CNI call#5026
mikebrow merged 1 commit intocontainerd:masterfrom
crosbymichael:cni-anno

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This additional information is helpful for CNI plugins when creating the network stack for a container. The plugin still has to have this capability added in its config to take advantage of this information.

ref: https://github.com/containernetworking/cni/blob/master/CONVENTIONS.md#dynamic-plugin-specific-fields-capabilities--runtime-configuration

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 9, 2021

Build succeeded.

@dmcgowan dmcgowan requested review from dims and mikebrow February 9, 2021 18:44
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Feb 9, 2021

--- FAIL: TestSnapshotterSuite/DevMapperUsage (0.73s)
        snapshotter_test.go:141: assertion failed: expression is false: layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize: 1179648 < 1179648

known flake not related to this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants