Add references to Windows 20H2 test images. by jeremyje · Pull Request #5025 · containerd/containerd

jeremyje · 2021-02-09T10:14:36Z

No description provided.

k8s-ci-robot · 2021-02-09T10:14:45Z

Hi @jeremyje. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-02-09T10:22:07Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 53s (non-voting)

thaJeztah

Thanks! Looks like you forgot to sign-off the commit (it's missing a signed-off-by line in the commit message); https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work

Signed-off-by: Jeremy Edwards <[email protected]>

theopenlab-ci · 2021-02-09T16:33:54Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 04s (non-voting)

thaJeztah · 2021-02-09T16:51:21Z

Hmm.. looks like there's some flakiness in other tests (at least, doesn't look related to this PR);

--- FAIL: TestSnapshotterSuite (0.67s)
    --- FAIL: TestSnapshotterSuite/DevMapperUsage (0.66s)
        snapshotter_test.go:141: assertion failed: expression is false: layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize: 1179648 < 1179648
FAIL
FAIL	github.com/containerd/containerd/snapshots/devmapper	39.953s
ok  	github.com/containerd/containerd/snapshots/devmapper/dmsetup	0.639s
ok  	github.com/containerd/containerd/snapshots/native	7.604s
ok  	github.com/containerd/containerd/snapshots/overlay	15.367s
FAIL
Makefile:177: recipe for target 'root-test' failed
make: *** [root-test] Error 1
Error: Process completed with exit code 2.

thaJeztah

LGTM

jeremyje · 2021-02-09T16:58:46Z

/retest

k8s-ci-robot · 2021-02-09T16:59:02Z

@jeremyje: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thaJeztah · 2021-02-09T17:05:51Z

/ok-to-test

thaJeztah · 2021-02-09T17:06:10Z

/retest

jeremyje · 2021-02-09T18:54:50Z

/retest

kevpar

LGTM

jeremyje · 2021-02-11T18:39:20Z

How do I trigger that test to run again?

jeremyje · 2021-02-11T18:43:31Z

/retest

jeremyje · 2021-02-12T07:18:58Z

/retest

AkihiroSuda · 2021-02-12T07:29:35Z

@jeremyje "Re-run jobs" can be used for restarting GHA https://docs.github.com/en/actions/managing-workflow-runs/re-running-a-workflow

(I already clicked the button)

thaJeztah · 2021-02-12T11:25:40Z

@AkihiroSuda I think that's only available for users with write access; at least, button doesn't show for me;

AkihiroSuda · 2021-02-12T13:00:29Z

🤦‍♂️

Then the only available option would be to amend the commit message slightly and push...

thaJeztah · 2021-02-12T13:55:30Z

Let me try if closing/re-opening still works as a workaround.

thaJeztah · 2021-02-12T13:55:54Z

yup, that looks to work

theopenlab-ci · 2021-02-12T14:03:55Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 42s (non-voting)

crosbymichael · 2021-02-12T16:58:40Z

LGTM

k8s-ci-robot added the needs-ok-to-test label Feb 9, 2021

thaJeztah requested changes Feb 9, 2021

View reviewed changes

Add references to Windows 20H2 test images.

1c81071

Signed-off-by: Jeremy Edwards <[email protected]>

thaJeztah approved these changes Feb 9, 2021

View reviewed changes

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Feb 9, 2021

AkihiroSuda approved these changes Feb 10, 2021

View reviewed changes

fuweid requested a review from kevpar February 10, 2021 23:09

kevpar approved these changes Feb 11, 2021

View reviewed changes

thaJeztah closed this Feb 12, 2021

thaJeztah reopened this Feb 12, 2021

crosbymichael merged commit 41e3057 into containerd:master Feb 12, 2021

Conversation

jeremyje commented Feb 9, 2021

Uh oh!

k8s-ci-robot commented Feb 9, 2021

Uh oh!

theopenlab-ci Bot commented Feb 9, 2021

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci Bot commented Feb 9, 2021

Uh oh!

thaJeztah commented Feb 9, 2021

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

jeremyje commented Feb 9, 2021

Uh oh!

k8s-ci-robot commented Feb 9, 2021

Uh oh!

thaJeztah commented Feb 9, 2021

Uh oh!

thaJeztah commented Feb 9, 2021

Uh oh!

jeremyje commented Feb 9, 2021

Uh oh!

kevpar left a comment

Choose a reason for hiding this comment

Uh oh!

jeremyje commented Feb 11, 2021

Uh oh!

jeremyje commented Feb 11, 2021

Uh oh!

jeremyje commented Feb 12, 2021

Uh oh!

AkihiroSuda commented Feb 12, 2021

Uh oh!

thaJeztah commented Feb 12, 2021

Uh oh!

AkihiroSuda commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Feb 12, 2021

Uh oh!

thaJeztah commented Feb 12, 2021

Uh oh!

theopenlab-ci Bot commented Feb 12, 2021

Uh oh!

crosbymichael commented Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AkihiroSuda commented Feb 12, 2021 •

edited

Loading