Fix repeated sending signal by wzshiming · Pull Request #5021 · containerd/containerd

wzshiming · 2021-02-08T09:40:34Z

Fixes #5020
xref kubernetes/kubernetes#98507

k8s-ci-robot · 2021-02-08T09:40:42Z

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-02-08T09:47:59Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 47s (non-voting)

k8s-ci-robot · 2021-02-08T09:48:29Z

@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wzshiming · 2021-02-08T09:51:55Z

/assign mikebrow
Could you have time to take a look please.

theopenlab-ci · 2021-02-08T10:07:20Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 06s (non-voting)

theopenlab-ci · 2021-02-08T13:40:28Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 47s (non-voting)

theopenlab-ci · 2021-02-09T16:13:10Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 52s (non-voting)

k8s-ci-robot · 2021-02-09T16:28:37Z

@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-02-09T16:37:46Z

@wzshiming: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-02-09T16:47:49Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 33s (non-voting)

mikebrow

Looking good.. see comments.

Note to self: should probably open an issue for a cri-tools verify test for async double stoping a container with two timeouts > 0 (long then short)..

wzshiming · 2021-02-09T17:17:58Z

@mikebrow
Thanks, updated.

theopenlab-ci · 2021-02-09T17:20:37Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 14s (non-voting)

mikebrow

just a small/nit refactor

mikebrow · 2021-02-09T18:39:45Z

--- FAIL: TestSnapshotterSuite/DevMapperUsage (0.71s)
        snapshotter_test.go:141: assertion failed: expression is false: layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize: 1179648 < 1179648

^ is a known flake

theopenlab-ci · 2021-02-10T02:35:26Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 47s (non-voting)

wzshiming · 2021-02-10T03:22:27Z

@mikebrow
Thanks, updated.

mikebrow

LGTM

fuweid

@wzshiming please sign your real name, thanks~

theopenlab-ci · 2021-02-17T13:08:08Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

wzshiming · 2021-02-17T13:09:22Z

@fuweid
Updated.

fuweid

LGTM on green

Need to add some cases in follow-up.

theopenlab-ci · 2021-02-17T13:23:08Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

wzshiming · 2021-02-17T13:29:43Z

Sorry, I forgot to update the author just now. updated.

Signed-off-by: Shiming Zhang <[email protected]>

theopenlab-ci · 2021-02-17T13:34:44Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

mikebrow

LGTM

mikebrow · 2021-02-22T15:57:17Z

LGTM on green

Need to add some cases in follow-up.

Did you want to open a new issue for the additional case(s).. restart, other cli / entry points...

k8s-ci-robot added the needs-ok-to-test label Feb 8, 2021

k8s-ci-robot assigned mikebrow Feb 8, 2021

wzshiming force-pushed the fix/signal_repeatedly branch 2 times, most recently from 2310ca4 to b813be1 Compare February 8, 2021 09:59

wzshiming force-pushed the fix/signal_repeatedly branch from b813be1 to d2d8c26 Compare February 8, 2021 13:33

dims mentioned this pull request Feb 8, 2021

Allowed shortened grace period for pods in Kubelet kubernetes/kubernetes#98507

Closed

fuweid reviewed Feb 9, 2021

View reviewed changes

Comment thread pkg/cri/server/container_stop.go Outdated

wzshiming force-pushed the fix/signal_repeatedly branch 2 times, most recently from 2de0cf7 to 1f45b72 Compare February 9, 2021 16:09

wzshiming force-pushed the fix/signal_repeatedly branch from 1f45b72 to e0b92b1 Compare February 9, 2021 16:15

wzshiming force-pushed the fix/signal_repeatedly branch from e0b92b1 to 11b2095 Compare February 9, 2021 16:39

mikebrow reviewed Feb 9, 2021

View reviewed changes

Comment thread pkg/cri/server/container_stop.go Outdated

Comment thread pkg/cri/store/container/container.go Outdated

Comment thread pkg/cri/server/container_stop.go Outdated

Comment thread pkg/cri/server/container_stop.go Outdated

Comment thread pkg/cri/store/container/container.go Outdated

mikebrow reviewed Feb 9, 2021

View reviewed changes

Comment thread pkg/cri/store/container/container.go Outdated

wzshiming force-pushed the fix/signal_repeatedly branch from 11b2095 to 74f91da Compare February 9, 2021 17:12

mikebrow reviewed Feb 9, 2021

View reviewed changes

Comment thread pkg/cri/server/container_stop.go Outdated

wzshiming force-pushed the fix/signal_repeatedly branch from 74f91da to 9e81aa5 Compare February 10, 2021 02:28

mikebrow approved these changes Feb 10, 2021

View reviewed changes

fuweid requested changes Feb 17, 2021

View reviewed changes

wzshiming force-pushed the fix/signal_repeatedly branch from 9e81aa5 to 352ec92 Compare February 17, 2021 13:07

fuweid reviewed Feb 17, 2021

View reviewed changes

fuweid approved these changes Feb 17, 2021

View reviewed changes

wzshiming force-pushed the fix/signal_repeatedly branch from 352ec92 to 2dc5aa0 Compare February 17, 2021 13:22

Fix repeated sending signal

dc6f5ef

Signed-off-by: Shiming Zhang <[email protected]>

wzshiming force-pushed the fix/signal_repeatedly branch from 2dc5aa0 to dc6f5ef Compare February 17, 2021 13:34

mikebrow approved these changes Feb 22, 2021

View reviewed changes

mikebrow merged commit 9173d3e into containerd:master Feb 22, 2021

wzshiming deleted the fix/signal_repeatedly branch February 22, 2021 15:51

This was referenced Feb 24, 2021

[release/1.4] Fix repeated sending signal #5073

Closed

[release/1.3] Fix repeated sending signal #5074

Closed

[release/1.4] Fix repeated sending signal containerd/cri#1626

Closed

[release/1.3] Fix repeated sending signal containerd/cri#1627

Closed

Conversation

wzshiming commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 8, 2021

Uh oh!

theopenlab-ci Bot commented Feb 8, 2021

Uh oh!

k8s-ci-robot commented Feb 8, 2021

Uh oh!

wzshiming commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theopenlab-ci Bot commented Feb 8, 2021

Uh oh!

theopenlab-ci Bot commented Feb 8, 2021

Uh oh!

Uh oh!

theopenlab-ci Bot commented Feb 9, 2021

Uh oh!

k8s-ci-robot commented Feb 9, 2021

Uh oh!

k8s-ci-robot commented Feb 9, 2021

Uh oh!

theopenlab-ci Bot commented Feb 9, 2021

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wzshiming commented Feb 9, 2021

Uh oh!

theopenlab-ci Bot commented Feb 9, 2021

Uh oh!

mikebrow left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikebrow commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theopenlab-ci Bot commented Feb 10, 2021

Uh oh!

wzshiming commented Feb 10, 2021

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci Bot commented Feb 17, 2021

Uh oh!

wzshiming commented Feb 17, 2021

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci Bot commented Feb 17, 2021

Uh oh!

wzshiming commented Feb 17, 2021

Uh oh!

theopenlab-ci Bot commented Feb 17, 2021

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

mikebrow commented Feb 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

wzshiming commented Feb 8, 2021 •

edited

Loading

wzshiming commented Feb 8, 2021 •

edited

Loading

mikebrow left a comment •

edited

Loading

mikebrow commented Feb 9, 2021 •

edited

Loading